mreutegg commented on PR #962: URL: https://github.com/apache/jackrabbit-oak/pull/962#issuecomment-1578833818
> as you mentioned, you still plan to add some more tests. I agree that would be useful to have. I added more tests with https://github.com/apache/jackrabbit-oak/pull/962/commits/2676bd6a693ec05bc89d46059f6b921021393b50. Do you have more tests in mind I could add? > I was also thinking about benchmarks @reschke mentioned. I'm not too concerned about performance, but I will run some of our existing benchmarks and compare numbers. > Would it be possible to reproduce the an OutOfMemoryError by doing an excessive amount of moves? It is certainly possible to create such a test, but I don't see why this would be useful. > As additional testing input, I was wondering if some of the existing tests could be run wiht 2 rules : classicMove and neoMove - that might allow to immediately get some large testing coverage.. I was considering running all tests with classic and neo move, but then concluded cost outweighs benefits by far. The classic implementation was tested thoroughly so far whenever a test or application code did a move. I therefore decided to enable the new implementation by default and add more test coverage specifically for the classic implementation to get full test coverage even if it is not enabled by default anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
