kwin commented on code in PR #1044:
URL: https://github.com/apache/jackrabbit-oak/pull/1044#discussion_r1280454567
##########
oak-auth-external/pom.xml:
##########
@@ -187,7 +197,27 @@
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
- <artifactId>org.apache.sling.testing.osgi-mock</artifactId>
+ <artifactId>org.apache.sling.testing.osgi-mock.junit4</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.sling</groupId>
+ <artifactId>org.apache.sling.testing.osgi-mock.core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
Review Comment:
Why all the additional dependencies? Isn't the transitive dependencies from
osgi-mock enough?
It is unusual to reference OSGi Spec chapter dependencies only in test
classpath. In tests those are only used usually if the to-be tested code relies
on those spec chapters as well.
##########
oak-auth-external/pom.xml:
##########
@@ -187,7 +197,27 @@
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
- <artifactId>org.apache.sling.testing.osgi-mock</artifactId>
+ <artifactId>org.apache.sling.testing.osgi-mock.junit4</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
Review Comment:
junit4 depends on core, therefore you only reference the former in the
dependency usually in this case
(https://sling.apache.org/documentation/development/osgi-mock.html#maven-dependency)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
