kwin commented on code in PR #1044:
URL: https://github.com/apache/jackrabbit-oak/pull/1044#discussion_r1280664152
##########
oak-auth-external/pom.xml:
##########
@@ -187,7 +197,27 @@
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
- <artifactId>org.apache.sling.testing.osgi-mock</artifactId>
+ <artifactId>org.apache.sling.testing.osgi-mock.junit4</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.sling</groupId>
+ <artifactId>org.apache.sling.testing.osgi-mock.core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
Review Comment:
but all those are transitive ones of
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/blob/45fb63cb61615663e10ed3c9e612a3a3f6161c3e/core/pom.xml#L42
and the ITs don't leverage those APIs/spec chapter directly (only the Sling
Testing Mock uses them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
