nit0906 commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1328611316
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStore.java:
##########
@@ -38,12 +38,13 @@ public class FlatFileStore implements
Iterable<NodeStateEntry>, Closeable {
private final Closer closer = Closer.create();
private final BlobStore blobStore;
private final File storeFile;
+ private final File metadataFile;
private final NodeStateEntryReader entryReader;
private final Set<String> preferredPathElements;
private final Compression algorithm;
private long entryCount = -1;
- public FlatFileStore(BlobStore blobStore, File storeFile,
NodeStateEntryReader entryReader, Set<String> preferredPathElements,
Compression algorithm) {
+ public FlatFileStore(BlobStore blobStore, File storeFile, File
metadataFile, NodeStateEntryReader entryReader, Set<String>
preferredPathElements, Compression algorithm) {
Review Comment:
Should we make an interface IndexingStore (like IncrementalStore) and make
this class implement that. LAter on TreeStore can also implement the same
interface.
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStore.java:
##########
@@ -38,12 +38,13 @@ public class FlatFileStore implements
Iterable<NodeStateEntry>, Closeable {
private final Closer closer = Closer.create();
private final BlobStore blobStore;
private final File storeFile;
+ private final File metadataFile;
private final NodeStateEntryReader entryReader;
private final Set<String> preferredPathElements;
private final Compression algorithm;
private long entryCount = -1;
- public FlatFileStore(BlobStore blobStore, File storeFile,
NodeStateEntryReader entryReader, Set<String> preferredPathElements,
Compression algorithm) {
+ public FlatFileStore(BlobStore blobStore, File storeFile, File
metadataFile, NodeStateEntryReader entryReader, Set<String>
preferredPathElements, Compression algorithm) {
Review Comment:
Should we make an interface IndexingStore (like IncrementalStore) and make
this class implement that. Later on TreeStore can also implement the same
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
