nit0906 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329800056
########## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalStoreBuilder.java: ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.jackrabbit.oak.index.indexer.document.incrementalstore; + +import org.apache.jackrabbit.guava.common.collect.Iterables; +import org.apache.jackrabbit.oak.commons.Compression; +import org.apache.jackrabbit.oak.index.IndexHelper; +import org.apache.jackrabbit.oak.index.indexer.document.CompositeException; +import org.apache.jackrabbit.oak.index.indexer.document.flatfile.FlatFileNodeStoreBuilder; +import org.apache.jackrabbit.oak.index.indexer.document.flatfile.LZ4Compression; +import org.apache.jackrabbit.oak.index.indexer.document.flatfile.NodeStateEntryReader; +import org.apache.jackrabbit.oak.index.indexer.document.flatfile.NodeStateEntryWriter; +import org.apache.jackrabbit.oak.spi.blob.BlobStore; +import org.jetbrains.annotations.NotNull; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.util.Collections; +import java.util.Objects; +import java.util.Set; +import java.util.function.Predicate; + +import static java.util.Collections.unmodifiableSet; + +public class IncrementalStoreBuilder { + private final Logger log = LoggerFactory.getLogger(getClass()); + + private final String INCREMENTAL_STORE_DIR_NAME_PREFIX = "inc-store"; + + private final File workDir; + private final IndexHelper indexHelper; + private final String initialCheckpoint; + private final String finalCheckpoint; + private Predicate<String> pathPredicate = path -> true; + private Set<String> preferredPathElements = Collections.emptySet(); + private BlobStore blobStore; + + private final boolean compressionEnabled = Boolean.parseBoolean(System.getProperty(FlatFileNodeStoreBuilder.OAK_INDEXER_USE_ZIP, "true")); + private final boolean useLZ4 = Boolean.parseBoolean(System.getProperty(FlatFileNodeStoreBuilder.OAK_INDEXER_USE_LZ4, "false")); + private final Compression algorithm = compressionEnabled ? (useLZ4 ? new LZ4Compression() : Compression.GZIP) : + Compression.NONE; + + + /** + * System property name for sort strategy. This takes precedence over {@link #INCREMENTAL_SORT_STRATEGY_TYPE}. + * Allowed values are the values from enum {@link IncrementalStoreBuilder.IncrementalSortStrategyType} + */ + public static final String INCREMENTAL_SORT_STRATEGY_TYPE = "oak.indexer.incrementalSortStrategyType"; + + + private final String sortStrategyTypeString = System.getProperty(INCREMENTAL_SORT_STRATEGY_TYPE); + private IncrementalStoreBuilder.IncrementalSortStrategyType sortStrategyType = sortStrategyTypeString != null + ? IncrementalStoreBuilder.IncrementalSortStrategyType.valueOf(sortStrategyTypeString) + : IncrementalSortStrategyType.INCREMENTAL_FFS_STORE; + + + public enum IncrementalSortStrategyType { + /** + * Incremental store having nodes updated between initial and final checkpoint + */ + + INCREMENTAL_FFS_STORE + } + + public IncrementalStoreBuilder(File workDir, IndexHelper indexHelper, + @NotNull String initialCheckpoint, @NotNull String finalCheckpoint) { + this.workDir = workDir; + this.indexHelper = indexHelper; + this.initialCheckpoint = Objects.requireNonNull(initialCheckpoint); + this.finalCheckpoint = Objects.requireNonNull(finalCheckpoint); + } + + public IncrementalStoreBuilder withPreferredPathElements(Set<String> preferredPathElements) { + this.preferredPathElements = preferredPathElements; + return this; + } + + public IncrementalStoreBuilder withSortStrategyType(IncrementalStoreBuilder.IncrementalSortStrategyType sortStrategyType) { + this.sortStrategyType = sortStrategyType; + return this; + } + + public IncrementalStoreBuilder withPathPredicate(Predicate<String> pathPredicate) { + this.pathPredicate = pathPredicate; + return this; + } + + public IncrementalStoreBuilder withBlobStore(BlobStore blobStore) { + this.blobStore = blobStore; + return this; + } + + + public IncrementalStore build() throws IOException, CompositeException { + logFlags(); + File dir = createStoreDir(); + + switch (sortStrategyType) { + case INCREMENTAL_FFS_STORE: + NodeStateEntryWriter entryWriter = new NodeStateEntryWriter(blobStore); + IncrementalIndexStoreSortStrategy strategy = new IncrementalFlatFileStoreStrategy( + indexHelper.getNodeStore(), + initialCheckpoint, + finalCheckpoint, + dir, preferredPathElements, algorithm, pathPredicate, entryWriter); + File metadataFile = strategy.createMetadataFile(); + File incrementalStoreFile = strategy.createSortedStoreFile(); + long entryCount = strategy.getEntryCount(); + IncrementalStore store = new IncrementalFlatFileStore(blobStore, incrementalStoreFile, metadataFile, + new NodeStateEntryReader(blobStore), + unmodifiableSet(preferredPathElements), algorithm); + if (entryCount > 0) { + store.setEntryCount(entryCount); + } + return store; + } + throw new IllegalStateException("Not a valid sort strategy value " + sortStrategyType); + } + + private File createStoreDir() throws IOException { + return Files.createTempDirectory(workDir.toPath(), getDirNamePrefix()).toFile(); + } + + private String getDirNamePrefix() { + return INCREMENTAL_STORE_DIR_NAME_PREFIX + sortStrategyTypeString; Review Comment: sortStrategyTypeString - this can be null if system property is not set , we should probably use the string rep of sortStrategyType instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
