tihom88 commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331178959
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -207,6 +212,29 @@ private List<FlatFileStore>
buildFlatFileStoreList(NodeState checkpointedState,
return storeList;
}
+ public IndexStore buildIncrementalStore(String initialCheckpoint, String
finalCheckpoint) throws IOException, CommitFailedException {
Review Comment:
I think changing method name will make it a little ambious. This method is
to create incrementalStore as it takes 2 checkpoints as inputs.
Though I am a little confused on should we have 2 interfaces IndexStore and
IncrementalIndexStore. If we do there won't be any change in both interfaces
for current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
