amit-jain commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331505640


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -207,6 +212,29 @@ private List<FlatFileStore> 
buildFlatFileStoreList(NodeState checkpointedState,
         return storeList;
     }
 
+    public IndexStore buildIncrementalStore(String initialCheckpoint, String 
finalCheckpoint) throws IOException, CommitFailedException {

Review Comment:
   On the surface both need to get checkpoints either between 0 -> c1 or c1 -> 
c2. So, just having it goverened by options should make it simpler to 
understand. 
   We probably don't need to have 2 different interfaces. But need to identify 
type (FFS, TreeFS), not sure if have to identify it as iincremental.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to