smiroslav commented on code in PR #1150:
URL: https://github.com/apache/jackrabbit-oak/pull/1150#discussion_r1360190637
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentBlob.java:
##########
@@ -192,6 +197,14 @@ public boolean equals(Object object) {
}
}
+ if (FAST_EQUALS_SAME_BLOBSTORE) {
+ if (blobStore != null && this.blobStore.equals(that.blobStore)
&& this.isExternal() && that.isExternal()) {
+ if (this.getContentIdentity() != null &&
that.getContentIdentity() != null) {
Review Comment:
Here, I believe we should use SegmentBlob#getBlobId. It returns not null
only for external blobs. Probably, in that case ```isExternal``` check is not
needed.
Besides that, ```getBlobId``` is not inherited from
```org.apache.jackrabbit.oak.api.Blob``` like ```getContentIdentity``` is (and
we should not use the latter one in a way that contradicts its contract).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
