dulceanu commented on code in PR #1150:
URL: https://github.com/apache/jackrabbit-oak/pull/1150#discussion_r1394042245
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentBlob.java:
##########
@@ -192,6 +197,14 @@ public boolean equals(Object object) {
}
}
+ if (FAST_EQUALS_SAME_BLOBSTORE) {
+ if (blobStore != null && this.blobStore.equals(that.blobStore)
&& this.isExternal() && that.isExternal()) {
+ if (this.getContentIdentity() != null &&
that.getContentIdentity() != null) {
Review Comment:
@smiroslav, based on our recent discussion I switched as advised to using
directly the blob id. However, I kept the checks for figuring out if the blob
is external or not for clarity and easier comprehension. Thanks for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
