t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1361878571
##########
oak-blob-cloud-azure/pom.xml:
##########
@@ -191,10 +191,10 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
- <groupId>com.arakelian</groupId>
- <artifactId>docker-junit-rule</artifactId>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers</artifactId>
+ <version>${testcontainers.version}</version>
Review Comment:
Defining a version in multi module project is always beneficial. The version
which is mentioned in the child's pom always received precedence over any
dependency conflicts, in this case the version is defined in parent pom which
in turn is used by all child modules.
I don't know why the same has not been done in other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
