t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366990047
##########
oak-blob-cloud-azure/pom.xml:
##########
@@ -191,10 +191,10 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
-
<dependency>
- <groupId>com.arakelian</groupId>
- <artifactId>docker-junit-rule</artifactId>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>testcontainers</artifactId>
+ <version>${testcontainers.version}</version>
Review Comment:
Yes we do that, but to be sure that other modules inherit the same version
of dependency that is declared in parent module and does not transitively use
some other version of same dependency, it will always beneficial to define the
version in child modules to avoid dependency conflicts.
If test container dependency is transitively inherited from other
dependency, we can end up using some other version than the one defined in
parent pom
https://stackoverflow.com/questions/13074231/override-library-version-defined-in-parent-pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
