nfsantos commented on code in PR #1159:
URL: https://github.com/apache/jackrabbit-oak/pull/1159#discussion_r1361924260
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java:
##########
@@ -86,10 +86,6 @@ public String toString(List<String> pathElements, String
nodeStateAsJson) {
}
public String asJson(NodeState nodeState) {
Review Comment:
I don't think we should change the behavior of this method, as this is
breaking the public contract. The API already had a method for returning node
with sorted properties and another unsorted, so there is no need to change the
behavior of the methods. Instead, it should be the API users that switch to
using the method that returns the properties sorted by name.
The Pipelined strategy is using this method and if you change the behavior,
this will affect its performance characteristics and may have other undesirable
effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
