thomasmueller commented on code in PR #1159:
URL: https://github.com/apache/jackrabbit-oak/pull/1159#discussion_r1362056063
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java:
##########
@@ -86,10 +86,6 @@ public String toString(List<String> pathElements, String
nodeStateAsJson) {
}
public String asJson(NodeState nodeState) {
Review Comment:
> this is breaking the public contract
"not sorting" is not the public contract... The public contract is just that
this is a JSON.
> this will affect its performance characteristics
According to the benchmark, it doesn't have a big impact: ~0.1 second for
100 MB
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java:
##########
@@ -86,10 +86,6 @@ public String toString(List<String> pathElements, String
nodeStateAsJson) {
}
public String asJson(NodeState nodeState) {
Review Comment:
Now, it doesn't sort by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
