nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366731245


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws 
IOException, CommitFailedExcept
     }
 
     public void reindex() throws CommitFailedException, IOException {
+        log.info("[TASK:INDEXING_JOB:START] Starting indexing job");

Review Comment:
   I was unsure about the name. Here we want to denote the full time of the 
job, so including building the FFS, indexing, upload files, catchup. But one of 
the phases of the job is the actual indexing. So if we call reindex for the 
total duration and indexing for duration of indexing, this is also confusing. I 
though that INDEXING_JOB would be a better name to denote the total time, but 
I'm open to other suggestions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to