chibulcuteanu commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366763796


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws 
IOException, CommitFailedExcept
     }
 
     public void reindex() throws CommitFailedException, IOException {
+        log.info("[TASK:INDEXING_JOB:START] Starting indexing job");

Review Comment:
   I got confused by the method it was in: `reindex`. I think something more 
generic should be used for the name (for the entire process) and not 
`INDEXING_JOB`. 
   Some proposals:
   - `Full Index Creation` - for the whole process
   - `Indexing` - for the actual indexing process - we should also probably not 
use `reindexing` anymore
   - `Ingestion` - for the upload part



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to