anchela commented on code in PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1371688768
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProvider.java:
##########
@@ -209,6 +203,21 @@ public Iterator<? extends Principal> findPrincipals(int
searchType) {
}
//------------------------------------------------------------< private
>---
+
+ GroupPrincipalFactory createGroupPrincipalFactory() {
Review Comment:
return value should be annotated with @NotNull
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProvider.java:
##########
@@ -209,6 +203,21 @@ public Iterator<? extends Principal> findPrincipals(int
searchType) {
}
//------------------------------------------------------------< private
>---
+
+ GroupPrincipalFactory createGroupPrincipalFactory() {
Review Comment:
return value should be annotated with @NotNull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
