anchela commented on code in PR #1128:
URL: https://github.com/apache/jackrabbit-oak/pull/1128#discussion_r1371690609
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserPrincipalProvider.java:
##########
@@ -209,6 +203,21 @@ public Iterator<? extends Principal> findPrincipals(int
searchType) {
}
//------------------------------------------------------------< private
>---
+
+ GroupPrincipalFactory createGroupPrincipalFactory() {
Review Comment:
missing annotation of return value (adding notnull would be the correct one
afaik).
i am wondering why this method is not private. IMHO nobody outside this
class should use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
