steffenvan commented on code in PR #1182:
URL: https://github.com/apache/jackrabbit-oak/pull/1182#discussion_r1385331690
##########
oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMergeSortTaskTest.java:
##########
@@ -89,27 +94,41 @@ private PipelinedMergeSortTask.Result runTest(Compression
algorithm, Path... fil
Path sortRoot = sortFolder.getRoot().toPath();
Review Comment:
Would it make sense to have a setup/teardown function for instantiating
these objects? Like the root, `ScheduledExecutorService` and
`MetricStatisticsProvider`? Then it would clearly signal that it is being
instantiated for each test case. And we can ensure to deregister the statistics
provider etc after each test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
