fabriziofortino commented on code in PR #1182: URL: https://github.com/apache/jackrabbit-oak/pull/1182#discussion_r1395720389
########## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/MetricsUtils.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.jackrabbit.oak.index.indexer.document.flatfile.pipelined; + +interface PipelinedMetrics { Review Comment: this is considered by many an antipattern (see Constant interface anti-pattern). In general, I tend to have the constant in the classes where they are used most. Arguments are mainly stylistic, so feel free to find alternatives. ########## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedStrategy.java: ########## @@ -222,9 +226,10 @@ private static void prettyPrintTransformStatisticsHistograms(TransformStageStati /** - * @param pathPredicate Used by the transform stage to test if a node should be kept or discarded. - * @param pathFilters If non-empty, the download stage will use these filters to try to create a query that downloads - * only the matching MongoDB documents. + * @param pathPredicate Used by the transform stage to test if a node should be kept or discarded. + * @param pathFilters If non-empty, the download stage will use these filters to try to create a query that downloads + * only the matching MongoDB documents. + * @param statisticsProvider Review Comment: add a description or remove the `@param` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
