fabriziofortino commented on code in PR #1193:
URL: https://github.com/apache/jackrabbit-oak/pull/1193#discussion_r1389160373
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java:
##########
@@ -286,23 +280,31 @@ public void afterBulk(long executionId, BulkRequest
bulkRequest, BulkResponse bu
}
@Override
- public void afterBulk(long executionId, BulkRequest bulkRequest,
Throwable throwable) {
- LOG.error("ElasticIndex Update Bulk Failure : Bulk with id {}
threw an error", executionId, throwable);
- suppressedExceptions.add(throwable);
+ public void afterBulk(long executionId, BulkRequest request,
List<String> contexts, Throwable failure) {
Review Comment:
when the bulk processor gets closed if there are suppressed exceptions,
they are grouped in a IOException that gets thrown. We have some tests around
this (see `ElasticPropertyIndexTest#indexFailuresWithFailOnErrorOn`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
