fabriziofortino commented on code in PR #1193:
URL: https://github.com/apache/jackrabbit-oak/pull/1193#discussion_r1389181756
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java:
##########
@@ -142,44 +134,58 @@ public static ElasticBulkProcessorHandler
getBulkProcessorHandler(@NotNull Elast
return new ElasticBulkProcessorHandler(elasticConnection, indexName,
indexDefinition, definitionBuilder, waitForESAcknowledgement);
}
- private BulkProcessor initBulkProcessor() {
- return BulkProcessor.builder(requestConsumer(),
- new OakBulkProcessorListener(), this.indexName +
"-bulk-processor")
- .setBulkActions(indexDefinition.bulkActions)
- .setConcurrentRequests(BULK_PROCESSOR_CONCURRENCY)
- .setBulkSize(new ByteSizeValue(indexDefinition.bulkSizeBytes))
-
.setFlushInterval(TimeValue.timeValueMillis(indexDefinition.bulkFlushIntervalMs))
- .setBackoffPolicy(BackoffPolicy.exponentialBackoff(
-
TimeValue.timeValueMillis(indexDefinition.bulkRetriesBackoff),
indexDefinition.bulkRetries)
- )
- .build();
+ private BulkIngester<String> initBulkIngester() {
+ // BulkIngester does not support retry policies. Some retries though
are already implemented in the transport layer.
Review Comment:
Makes sense. I have removed them. I think bulk retries should be made
configurable at ElasticConnection level. This will be addressed in a separate
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
