smiroslav commented on PR #1204: URL: https://github.com/apache/jackrabbit-oak/pull/1204#issuecomment-1808610486
> What about the SegmentWriteQueue? All the segments already in the queue can still be sent to Azure even though the lease cannot be renewed. No, if those writes and journal updates compete with writes from the new Oak process that has successfully acquired the lease. > Instead of blocking calls to AzureSegmentArchiveWriter, shouldn't we block adding new segment to the SegmentWriteQueue and block consuming its internal queue? It is also possible to configure synchronous writes when there is not queue https://github.com/apache/jackrabbit-oak/blob/e96cfcb52866e33601a939d13c1e1091fd9ff72c/oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/AbstractRemoteSegmentArchiveWriter.java#L59-L59 Check happens in the method below which is invoked also when queue is not configured https://github.com/apache/jackrabbit-oak/blob/e96cfcb52866e33601a939d13c1e1091fd9ff72c/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriter.java#L62-L62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
