jelmini commented on PR #1204: URL: https://github.com/apache/jackrabbit-oak/pull/1204#issuecomment-1809622960
>> What about the `SegmentWriteQueue`? All the segments already in the queue can still be sent to Azure even though the lease cannot be renewed. > No, if those writes and journal updates compete with writes from the new Oak process that has successfully acquired the lease. I'm not sure I understand. As far as I can see, `SegmentWriteQueue` does not check if the lease is held by the current instance when writing to Azure. Thus, if the queue is full when writes are blocked by `WriteAccessController` and Azure is slow, there could still be segments uploaded after the lease is lost. For uploads already in progress when writes are blocked, we should probably just let them finish. But we should block all new uploads from starting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
