nfsantos commented on code in PR #1202:
URL: https://github.com/apache/jackrabbit-oak/pull/1202#discussion_r1397026797
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/NodeStateEntryBatch.java:
##########
@@ -51,49 +49,46 @@ public static NodeStateEntryBatch
createNodeStateEntryBatch(int bufferSizeBytes,
}
private final ByteBuffer buffer;
- private final ArrayList<SortKey> sortBuffer;
private final int maxEntries;
+ private int numberOfEntries = 0;
Review Comment:
As discussed privately, I prefer to initialize the values explicitly, to
convey the intention that 0 is the initial value for the field, as opposed to a
variable that is not assigned in its definition because it will be initialized
in the construtor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
