nfsantos commented on code in PR #1202:
URL: https://github.com/apache/jackrabbit-oak/pull/1202#discussion_r1397087798
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedStrategy.java:
##########
@@ -270,10 +271,9 @@ public PipelinedStrategy(MongoDocumentStore documentStore,
Preconditions.checkArgument(numberOfTransformThreads > 0,
"Invalid value for property " +
OAK_INDEXER_PIPELINED_TRANSFORM_THREADS + ": " + numberOfTransformThreads + ".
Must be > 0");
- // Derived values for transform <-> sort-save
- int nseBuffersReservedMemoryMB = readNSEBuffersReservedMemory();
-
- // Calculate values derived from the configuration settings
+ int sortBufferMemoryPercentage =
ConfigHelper.getSystemPropertyAsInt(OAK_INDEXER_PIPELINED_SORT_BUFFER_MEMORY_PERCENTAGE,
DEFAULT_OAK_INDEXER_PIPELINED_SORT_BUFFER_MEMORY_PERCENTAGE);
+ Preconditions.checkArgument(sortBufferMemoryPercentage > 0 &&
sortBufferMemoryPercentage <= 100,
+ "Invalid value for property " +
OAK_INDEXER_PIPELINED_TRANSFORM_THREADS + ": " + numberOfTransformThreads + ".
Must be > 0");
Review Comment:
Good point. In fact, it should say between 1 and 100, 0 is not a valid
value. It was also printing the wrong name of the property. I fixed the
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
