anchela commented on PR #1128: URL: https://github.com/apache/jackrabbit-oak/pull/1128#issuecomment-2149051571
@mreutegg , since you were the author of the initial proposal, I would like to get another review from your side to see if the refactoring I made last week, still meets your approach. most importantly: I found the logic and when to remove entries from the updates-map not easy to understand and therefore refactored the code such that the updates-map will always get the entry removed upon completion (successful or unsuccessful). in other words: if there is no entry for a given path, it is added notifying other threads about a current update and in the finally clause it is always removed. at the same time i removed the logic of keeping the previous exp-time (or 0) as value, which i didn't find intuitive to understand even after several reviews and instead used the thread-id as value. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
