reschke commented on code in PR #362: URL: https://github.com/apache/jackrabbit-filevault/pull/362#discussion_r1990188179
########## vault-core/src/main/java/org/apache/jackrabbit/vault/fs/api/WorkspaceFilter.java: ########## @@ -102,6 +103,19 @@ public interface WorkspaceFilter extends Dumpable { */ boolean isAncestor(@NotNull String path); + /** + * Matches the given path with all filter roots. For each, if it is an ancestor, + * add the name of the first path segment of the remaining filter root "below" path + * to the result set. + * + * @param path Path to check + * @return first path segments of non-matched paths, or {@code null} when result set Review Comment: It would return null, because in that case we can't optimize? So clarify the docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org