reschke commented on code in PR #362:
URL:
https://github.com/apache/jackrabbit-filevault/pull/362#discussion_r1992037094
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/api/FilterSet.java:
##########
@@ -239,12 +243,45 @@ public boolean covers(@NotNull String path) {
}
/**
- * Checks if the given item is an ancestor of the root node.
+ * Checks if the given item is an ancestor of the filter's root path.
Review Comment:
Yes. What I meant was: this is consistent with the Javadoc for other methods
here - such as `covers()`. Should I use the opportunity to fix those as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
