Hi list,
after talking to Dan at QCon I finally had the time looking at JBehave.
Its approach is very promising although it feels a bit strange when being
used to junit all time long.
I looked at your code and like it very much by now. Great usage of
interfaces and encapsulation of implemenations.
Some things:
* either in UsingMatchers recurses infinitely, a call to or() should fit
there
* perhaps it would be convenient to have static inner classes for the
different custom matchers? This should speed things a bit up instead of
using dynamic class creation.
* at least the static implementations like anything() and perhaps a future
nothing() could be stored as immutable constants which are returned at
every call
* TimoutException referered to an SwingBehaviourException which is only
contained in the extensions/swing module (which is missing from the IDEA
project file), as TimeoutException is in the core package an circular
dependency is introduced to the swing extension module
It seems that the ATM example is not really functional?
Thanks alot
Michael
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
