"Michael Hunger" <[EMAIL PROTECTED]> wrote on 22/03/2007 02:05:17:
> * either in UsingMatchers recurses infinitely, a call to or() should fit > there Fixed! > * perhaps it would be convenient to have static inner classes for the > different custom matchers? This should speed things a bit up instead of > using dynamic class creation. I looked at this, but the ability to override matchers is very useful. Examples: - I have a custom collection, and want to define my own isContainedIn(). - I am using Hibernate, and want to add the de-proxifier to eq(). - I want anything() to check for my special null implementation marker interface too. I'd prefer to keep these dynamic for that reason. > * at least the static implementations like anything() and perhaps a future > nothing() could be stored as immutable constants which are returned at > every call See above. nothing() is a great idea and will make some code more readable. I've added it. > * TimoutException referered to an SwingBehaviourException which is only > contained in the extensions/swing module (which is missing from the IDEA > project file), as TimeoutException is in the core package an circular > dependency is introduced to the swing extension module I have fixed this, and deleted SwingBehaviourException. > It seems that the ATM example is not really functional? You're right! Fortunately we have a lovely Hellbound game which serves as a great functional example, so I've added some text to the ATM example. I think it was mostly written for the StoryPrinter anyway. Thank you! Hope this fixes the biggest of your problems; please do let us know if you come across any more. Cheers, Liz. -- Elizabeth Keogh [EMAIL PROTECTED] http://www.livejournal.com/users/sirenian
