[
http://jira.codehaus.org/browse/JBEHAVE-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=229787#action_229787
]
Brian Repko commented on JBEHAVE-327:
-------------------------------------
Cristiano,
Thanks for the comment - good to know the "why".
One can walk the class hierarchy tree and do that work (just like walking
interfaces and superclasses to look for un-inherited annotations). That is no
different than how Spring-Test's @ContextConfiguration works. But the actual
reading of the annotation information doesn't require javassist.
Do we always combine arrays for every annotation or do we need a boolean
parameter on some of those methods? What about interfaces?
Brian
> Remove dependency on javassist by using standard JDK annotation functionality
> -----------------------------------------------------------------------------
>
> Key: JBEHAVE-327
> URL: http://jira.codehaus.org/browse/JBEHAVE-327
> Project: JBehave
> Issue Type: Improvement
> Components: Core
> Affects Versions: 3.0
> Reporter: Brian Repko
> Attachments: AnnotationFinder.java
>
>
> Use of javassist is typically done for access to non-RUNTIME Retention
> annotations or for annotation parsing over a large set of classes when you
> don't want to load the class. We don't have those use cases and thus can
> eliminate the javassist dependency in AnnotationFinder.
> New version of AnnotationFinder is attached that seems to work - I wasn't
> sure if getAnnotation should look at interfaces and/or superclasses (not
> needed if we appropriate add the @Inherited to our annotations).
> jbehave-core/pom.xml also changed to remove the dependency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
