[ 
http://jira.codehaus.org/browse/JBEHAVE-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=230340#action_230340
 ] 

Mauro Talevi commented on JBEHAVE-327:
--------------------------------------

Applied patches 1 and 2 (after battling with issues with training whitespace). 

Not yet applied 3:  I agree with making the inheritance behaviour configurable, 
but would like to avoid proliferation of boolean properties in multiple 
annotations.  Rather, we could introduce another separate annotation, say 
@UsingInheritance, that could be used independently of the method of 
composition used.  WDYT?


> Remove dependency on javassist by using standard JDK annotation functionality
> -----------------------------------------------------------------------------
>
>                 Key: JBEHAVE-327
>                 URL: http://jira.codehaus.org/browse/JBEHAVE-327
>             Project: JBehave
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brian Repko
>            Assignee: Mauro Talevi
>             Fix For: 3.0
>
>         Attachments: 0001-removal-of-javassist.patch, 
> 0002-merge-change-of-Exception-type.patch, 
> 0003-add-support-for-inherited-annotation-values.patch, AnnotationFinder.java
>
>
> Use of javassist is typically done for access to non-RUNTIME Retention 
> annotations or for annotation parsing over a large set of classes when you 
> don't want to load the class.  We don't have those use cases and thus can 
> eliminate the javassist dependency in AnnotationFinder.
> New version of AnnotationFinder is attached that seems to work - I wasn't 
> sure if getAnnotation should look at interfaces and/or superclasses (not 
> needed if we appropriate add the @Inherited to our annotations).
> jbehave-core/pom.xml also changed to remove the dependency.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to