>                 return input.get() != null;
>              }
>           }, operationCompleteCheckTimeout, operationCompleteCheckInterval, 
> MILLISECONDS).apply(instance);
>        }
>  
> -      InstanceInZone instanceInZone = new InstanceInZone(instance.get(), 
> template.getLocation().getId());
> +      // Add tags for security groups
> +      final FirewallTagNamingConvention naming = 
> firewallTagNamingConvention.get(group);
> +      Set<String> tags = 
> FluentIterable.from(Ints.asList(options.getInboundPorts()))
> +              .transform(new Function<Integer, String>(){
> +                       @Override
> +                       public String apply(Integer input) {
> +                          return input != null

The Guava `Function` interface has an `@Nullable` annotation on the parameter 
to `apply()`. As a habit, whenever writing a `Function` implementation, I 
always check that the input is non-null, even if it's unlikely to be the case. 
Some smart IDEs see the nullable annotation and show warnings if it is absent. 
That's my convention however, and I can remove this if you'd prefer.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33/files#r7524336

Reply via email to