> + */
> +package org.jclouds.googlecomputeengine.compute.functions;
> +
> +import com.google.common.base.Predicate;
> +import org.jclouds.compute.functions.GroupNamingConvention;
> +
> +import javax.inject.Inject;
> +
> +/**
> + * The convention for naming instance tags that firewall rules recognise.
> + * 
> + * @author richardcloudsoft
> + */
> +public class FirewallTagNamingConvention {
> +
> +   public static class Factory {

This class is more like the existing 
org.jclouds.compute.functions.GroupNamingConvention, which uses the Factory 
pattern. Also, this class participates in dependency injection, which Builders 
do not.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33/files#r7526918

Reply via email to