Hi Andrea, Thanks so much! Absolutely! I will test this out and get back to you with my findings.
Thanks Imesh On Wed, Mar 12, 2014 at 7:08 PM, Andrea Turli <andrea.tu...@gmail.com>wrote: > Hi Imesh, > > I've committed a new version of soflayer on my branch `refactor/softlayer` > commit 56931cb9599d251122828b462c2fae2f171f56b6 > > It would be nice if you can test it and report on ML your > feedback/impressions. > > Thanks, > > Andrea > > > On Wed, Mar 12, 2014 at 10:21 PM, Andrea Turli <andrea.tu...@gmail.com > >wrote: > > > Hi Imesh, > > > > glad to hear you've been able to test my branch. As I said, we are > > currently actively working on that branch so it is not stabilized yet, > and > > for that reason you got different version pulling the code in two > different > > moments. > > > > I'm going to push a new commit shortly so I will ping you when it is out > > if you like to test it again. > > > > Thanks, > > Andrea > > > > > > On Wed, Mar 12, 2014 at 10:00 PM, Imesh Gunaratne <im...@apache.org > >wrote: > > > >> Hi Andrea, > >> > >> Thank you very much. Really appreciate it. > >> > >> I applied your pull request to my local repository and did a test. Yes > it > >> was much stable than the master. However I found one issue when trying > to > >> spawn an instance. The OperatingSystemReferenceCode property was not set > >> in > >> the request. > >> > >> > >> > org.jclouds.softlayer.compute.strategy.SoftLayerComputeServiceAdapter.createNodeWithGroupEncodedIntoName(): > >> > >> operatingSystem = OperatingSystem.builder() > >> .id(from.getId()) > >> .build(); > >> > >> I update this logic to set the above property and the issue was fixed. > >> > >> BTW today I accidently deleted the .git folder in my local repository > and > >> tried to fetch your pull request again. What I did was: > >> > >> git clone https://github.com/apache/jclouds.git > >> git fetch https://github.com/jclouds/jclouds.git refs/pull/296/head > >> > >> But as I found the new checkout I got was different from my previous. > >> Could > >> you please guide me how to fetch your pull request to a fresh local > >> repository? > >> > >> Thanks > >> Imesh > >> > >> > >> On Mon, Mar 10, 2014 at 11:30 AM, Andrea Turli <andrea.tu...@gmail.com > >> >wrote: > >> > >> > Imesh, > >> > > >> > Just to clarify, if I checkout 1.7.1 branch and apply this pull > request > >> on > >> > > top would it be ok for the moment? > >> > > > >> > > >> > It should be ok, even if it can be unstable. > >> > > >> > Best, > >> > Andrea > >> > > >> > >> > >> > >> -- > >> Imesh Gunaratne > >> > >> Technical Lead, WSO2 > >> Committer & PPMC Member, Apache Stratos > >> > > > > > -- Imesh Gunaratne Technical Lead, WSO2 Committer & PPMC Member, Apache Stratos
