the PR gets merged (or we could add Guice to the version matrix we have in the Guava compatibility builds).
Just created a matrix build for Guice compatibility for the PR, actually ;-). Thanks for figuring out the refspec on this one, Ignasi!
https://jclouds.ci.cloudbees.com/job/jclouds-guice-3-4/
In any case, the fix does not change the Guice version; just makes the code Guice 4 friendly.
Er...oops, lazy me :-( Sorry about the confusion. In this case, I'd say the change itself looks fine - the main stumbling block would be if many users are relying on the ability to override providers in their current code. At the very least, we'd need to provide a documented migration path for them.
I hope there aren't many because, as far as I recall, our default recommendation here has been to create a new module and override the *binding* in there, but it would be good to try to verify that.
Regards ap
