Cool, thanks Valentin! :)

Just did a veeery quick share, plus, added some of the issues to the README:

https://github.com/mishmash-io/jclouds-labs/tree/master/hetzner

I think it's kind of too early to submit a pull request though... 


 ---- On Sun, 25 Feb 2018 13:21:20 +0200 Valentin AItken <valen...@nalisbg.com> 
wrote ---- 
 > Hi Andrey, 
 >  
 > Glad to see more contributors in jclouds! 
 >  
 > You did successfully the "0." step from the contribution guide [1] 
 >  
 > Regarding reviewing and discussing the code, I suggest you commit it in 
 > jclouds-labs [2], fork it, push it and submit a Pull Request. 
 > I find PR discussions very benefitial. 
 >  
 > Valentin. 
 >  
 > [1] https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribu 
 > te 
 > [2] https://github.com/jclouds/jclouds-labs 
 >  
 >  
 > В 13:00 +0200 на 25.02.2018 (нд), Andrey Rusev написа: 
 > > Hello all,  
 > >  
 > > We did a very quick implementation of a cloud provider we use ( https 
 > > ://www.hetzner.com/cloud ) and I thought we might share it so that 
 > > other people can use it too. And then I thought we better do it 
 > > properly. As none of us is really an expert on jclouds internals, 
 > > plans, etc I'd like some help with figuring out what would be the 
 > > right way to plug it in, use all available abstractions so that the 
 > > api is as transparent as any other and so on.  
 > >  
 > > For example - at the moment we have a ComputeServiceAdapter that only 
 > > does the basics, but it feels to me a lot of functionality is left 
 > > out. Unless you unwrap() the lower-level API or add some metadata 
 > > key-values (that might 'brake' comparators or something else?).  
 > >  
 > > If anyone is happy to help with some guidance please let me know!  
 > >  
 > > Also - where do I share the code? Load it somewhere on github? Or 
 > > with a link to download?  
 > >  
 > > Cheers,  
 > > Andrey  
 > >  
 > >  
 > >  
 > >  
 > 


Reply via email to