Hi Andrew, Great job! I noticed you found some fgcp files with missing license header too.
Note that the change in your latest PR will cause fgcp unit tests to fail: You added the license header in XML form to jaxb.index. Jaxb.index is not an xml file, JAXB can't read it with XML in it. If you comment each line with '#' instead, it'll work fine. Let me know if you want me to do these files instead. Regards, Dies Koper > -----Original Message----- > From: Andrew Bayer [mailto:[email protected]] > Sent: Tuesday, 14 May 2013 10:15 AM > To: [email protected] > Subject: Re: Help with RAT Errors > > I think I've got the bulk (master/1.5.x/1.6.x in incubator-jclouds, > master/1.6.x in incubator-jclouds-labs) done - I'm expecting some test > failures here and there from tests that expect text files etc in > src/test/resources to be identical, but we'll deal with that later. If > you > want to go after other repos, feel free - I screwed up and put > <inherited>false</inherited> on the apache-rat-plugin definition while > also > forgetting to put <excludeSubProjects>false</excludeSubProjects> in the > apache-rat-plugin configuration, so that definitely has to change > everywhere. =) > > A. > > On Mon, May 13, 2013 at 5:09 PM, Suresh Marru <[email protected]> wrote: > > > Hi Andrew, > > > > I see you are working through the RAT errors and have few pull requests. > I > > can help out to fix the headers and stuff. Do you need any help? > > > > Suresh > > > >
