Headers MUST be /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */
Note the " Licensed to the Apache Software Foundation (ASF) ... " which is different from " Licensed to jclouds, Inc. (jclouds) ...." 2013/5/14 Koper, Dies <[email protected]>: > Hi Andrew, > > Great job! I noticed you found some fgcp files with missing license > header too. > > Note that the change in your latest PR will cause fgcp unit tests to > fail: > You added the license header in XML form to jaxb.index. > Jaxb.index is not an xml file, JAXB can't read it with XML in it. > If you comment each line with '#' instead, it'll work fine. > Let me know if you want me to do these files instead. > > Regards, > Dies Koper > > > >> -----Original Message----- >> From: Andrew Bayer [mailto:[email protected]] >> Sent: Tuesday, 14 May 2013 10:15 AM >> To: [email protected] >> Subject: Re: Help with RAT Errors >> >> I think I've got the bulk (master/1.5.x/1.6.x in incubator-jclouds, >> master/1.6.x in incubator-jclouds-labs) done - I'm expecting some test >> failures here and there from tests that expect text files etc in >> src/test/resources to be identical, but we'll deal with that later. If >> you >> want to go after other repos, feel free - I screwed up and put >> <inherited>false</inherited> on the apache-rat-plugin definition while >> also >> forgetting to put <excludeSubProjects>false</excludeSubProjects> in > the >> apache-rat-plugin configuration, so that definitely has to change >> everywhere. =) >> >> A. >> >> On Mon, May 13, 2013 at 5:09 PM, Suresh Marru <[email protected]> > wrote: >> >> > Hi Andrew, >> > >> > I see you are working through the RAT errors and have few pull > requests. >> I >> > can help out to fix the headers and stuff. Do you need any help? >> > >> > Suresh >> > >> > > -- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy
