+ 1 (IPMC Binding). I have trying to poke more into the release artifacts. I am a little concerned with NOTICE file populating inside the jars, but I will need to spend more time to raise concrete concerns. Since so far all the aspects I reviewed are good, I am voting + 1. Lets see whats others have to say on the general list. For next release, I will engage early on and will help with L, N files.
Good job over all, Suresh On Jun 16, 2013, at 8:46 PM, Suresh Marru <[email protected]> wrote: > Great progress Andrew with the release artifacts. I am in email catch up mode > and might have missed some discussion. So I will post some discussions first, > will hold vote for now pending this discussion. If these issues have been > discussed previously I will vote. Meanwhile, I will keep looking. > > The signatures all look good, maven builds of all sources success, the nexus > repo is correctly populated (see improvements below), with required NOTICE, > LICENSE and DISCLAIMER files. > > I am personally not sure "Copyright 2013 jclouds" is a blocker or not. The > instructions clearly say it has to be Apache $Project - > http://www.apache.org/legal/src-headers.html#notice > > I will not gate this and will vote positively, since the following line > clearly says the software is developed at ASF, but I will rely on other > mentor/IPMC opinion on this. > > The NOTICE.txt file in previous iterations (example: > https://repository.apache.org/content/repositories/orgapachejclouds-015/org/apache/jclouds/api/ec2/1.6.1-incubating/ec2-1.6.1-incubating.jar) > has significant dependency notices. Why did these notices did not get > populated into the current NOTICE file (example - > https://repository.apache.org/content/repositories/orgapachejclouds-016/org/apache/jclouds/api/ec2/1.6.1-incubating/ec2-1.6.1-incubating.jar) > > Here are some non-blocking comments and suggestions for future improvements: > > * Please instruct the release vote discussion to [VOTE] and [DISCUSS] > threads. As soon as you post the [VOTE] thread, immediately post a [DISCUSS] > email and encourage all review and discussions to discuss thread. The vote > thread is advised to only have votes. Quick reference examples [1], [2] > * Please try to post the release artifacts to official dev distribution area > [3] instead of your personal space - (Note the *dev*, this location is not > mirrored, the *release* area [4] will be). > * Fix the NOTICE file from jclouds to Apache jclouds > * Include Project metadata in the parent pom - Mailing List, Issue > Management, Developers. Example if needed [5]. > * As David already pointed out, try and have atleast 3 apache committers sign > your key. > * I would drop all the cancelled RC nexus repo's before pushing new RC's. > Currently you will see 7 staging repos - > https://repository.apache.org/index.html#stagingRepositories. Except the > orgapachejclouds-016, please drop others. > > Suresh > [1] - http://airavata.apache.org/development/release-vote.txt > [2] - http://airavata.apache.org/development/release-discuss.txt > [3] - https://dist.apache.org/repos/dist/dev/incubator/jclouds/ > [4] - https://dist.apache.org/repos/dist/release/incubator/jclouds/ > [5] - https://svn.apache.org/repos/asf/airavata/trunk/pom.xml > > On Jun 12, 2013, at 9:35 PM, Andrew Bayer <[email protected]> wrote: > >> Hello, >> >> This is the third release candidate for Apache jclouds 1.6.1-incubating, >> the first jclouds release at Apache. >> >> This is a PPMC vote - if this passes, we'll move it onward to an IPMC vote. >> >> It fixes the following issues: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12324412&styleName=Html&projectId=12314430 >> >> *** Please download, test and vote by Saturday, June 15th, 7pm PDT. >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary files: >> http://people.apache.org/~abayer/jclouds-1.6.1-incubating-candidate-3 >> >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachejclouds-016 >> >> The tags to be voted upon: >> - jclouds - >> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds.git;a=tag;h=8ed5571b0ecf7d79c64bc16642264684882f0311 >> - jclouds-labs - >> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-labs.git;a=tag;h=54b084e474e0c22b539ed7cce0b0ebbc82b310cb >> - jclouds-chef - >> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-chef.git;a=tag;h=4adced11f4e74513c06023d6b3cde0642fd4017f >> - jclouds-karaf - >> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-karaf.git;a=tag;h=9e1f0d14285c8edeb35499f313aa7dbfab4a86f6 >> - jclouds-cli - >> https://git-wip-us.apache.org/repos/asf?p=incubator-jclouds-cli.git;a=tag;h=2e3575f56de2bf67469782d94d72ce8e621ddda5 >> >> jclouds KEYS file containing PGP keys we use to sign the release: >> http://www.apache.org/dist/incubator/jclouds/KEYS >> >> [ ] +1 >> [ ] 0 >> [ ] -1 (explain why) >> >> A. >
