> +   @Override
> +   public SecurityGroup getSecurityGroupById(String id) {
> +      checkNotNull(id, "id");
> +      ZoneAndId zoneAndId = ZoneAndId.fromSlashEncoded(id);
> +      String zone = zoneAndId.getZone();
> +      String groupId = zoneAndId.getId();
> +
> +      Optional<? extends SecurityGroupApi> sgApi = 
> client.getSecurityGroupExtensionForZone(zone);
> +
> +      if (!sgApi.isPresent()) {
> +         return null;
> +      }
> +
> +      SecurityGroupInZone rawGroup = new 
> SecurityGroupInZone(sgApi.get().get(groupId), zone);
> +
> +      return groupConverter.apply(rawGroup);

Is "groupInZone2group" or something a bit more descriptive than 
"groupConverter"?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/144/files#r6344647

Reply via email to