> +         sgApi.get().delete(groupId);
> +         // TODO: test this clear happens
> +         groupCreator.invalidate(new ZoneSecurityGroupNameAndPorts(zone, 
> groupId, ImmutableSet.<Integer> of()));
> +         return true;
> +      }
> +
> +      return false;
> +   }
> +
> +
> +   @Override
> +   public SecurityGroup addIpPermission(IpPermission ipPermission, 
> SecurityGroup group) {
> +      String zone = group.getLocation().getId();
> +      String id = group.getId();
> +
> +      Optional<? extends SecurityGroupApi> sgApi = 
> client.getSecurityGroupExtensionForZone(zone);

No null check for `zone` here?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/144/files#r6344676

Reply via email to