Don't use bash `shopt` in the wrapper script, as some images with a bash 
shell don't support it. See 
[JCLOUDS-283](https://issues.apache.org/jira/browse/JCLOUDS-283) for the 
details about the motivation and the applied changes.

I've tested the change with jclouds-chef (which uses a quite complex 
wrapped script) and succesfully deployed a Wordpress in EC2 with an Ubuntu AMI 
(us-east-1/ami-d0f89fb9). The chef bootstrap script makes use of the aliases 
that have been transformed to a function, so the applied changes shouldn't 
break existing code.

@zack-shoylev, @everett-toews (or any OpenStack ninja :D) could you try this PR 
with a `cirrus` image or any other that used to fail?

You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds 283-remove-shopt

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/150

-- Commit Summary --

  * JCLOUDS-283: Don't use bash shopt in the wrapper script

-- File Changes --

    M compute/src/test/resources/initscript_with_java.sh (18)
    M compute/src/test/resources/initscript_with_jetty.sh (18)
    M compute/src/test/resources/runscript.sh (18)
    M compute/src/test/resources/runscript_adminUpdate.sh (4)
    M 
scriptbuilder/src/main/java/org/jclouds/scriptbuilder/domain/ShellToken.java (2)
    M scriptbuilder/src/main/resources/functions/setupPublicCurl.sh (14)
    M 
scriptbuilder/src/test/java/org/jclouds/scriptbuilder/domain/ShellTokenTest.java
 (18)
    M scriptbuilder/src/test/resources/test_ebs.sh (4)
    M scriptbuilder/src/test/resources/test_find_pid.sh (2)
    M scriptbuilder/src/test/resources/test_init.sh (4)
    M scriptbuilder/src/test/resources/test_init_script.sh (4)
    M scriptbuilder/src/test/resources/test_install_chef_gems_scriptbuilder.sh 
(4)
    M scriptbuilder/src/test/resources/test_install_git_scriptbuilder.sh (18)
    M scriptbuilder/src/test/resources/test_install_jdk_scriptbuilder.sh (18)
    M scriptbuilder/src/test/resources/test_install_ruby_scriptbuilder.sh (18)
    M scriptbuilder/src/test/resources/test_install_rubygems_scriptbuilder.sh 
(4)
    M scriptbuilder/src/test/resources/test_runrun.sh (2)
    M scriptbuilder/src/test/resources/test_runrun_header.sh (2)
    M scriptbuilder/src/test/resources/test_script.sh (2)
    M scriptbuilder/src/test/resources/test_seek_and_destroy.sh (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/150.patch
https://github.com/jclouds/jclouds/pull/150.diff

Reply via email to