I will give it a try later today or tomorrow. Thanks!! Zack ________________________________ From: Ignasi Barrera [[email protected]] Sent: Monday, September 16, 2013 11:17 AM To: jclouds/jclouds Cc: Zack Shoylev Subject: [jclouds] JCLOUDS-283: Don't use bash shopt in the wrapper script (#150)
Don't use bash shopt in the wrapper script, as some images with a bash shell don't support it. See JCLOUDS-283<https://issues.apache.org/jira/browse/JCLOUDS-283> for the details about the motivation and the applied changes. I've tested the change with jclouds-chef (which uses a quite complex wrapped script) and succesfully deployed a Wordpress in EC2 with an Ubuntu AMI (us-east-1/ami-d0f89fb9). The chef bootstrap script makes use of the aliases that have been transformed to a function, so the applied changes shouldn't break existing code. @zack-shoylev<https://github.com/zack-shoylev>, @everett-toews<https://github.com/everett-toews> (or any OpenStack ninja :D) could you try this PR with a cirrus image or any other that used to fail? ________________________________ You can merge this Pull Request by running git pull https://github.com/nacx/jclouds 283-remove-shopt Or view, comment on, or merge it at: https://github.com/jclouds/jclouds/pull/150 Commit Summary * JCLOUDS-283: Don't use bash shopt in the wrapper script File Changes * M compute/src/test/resources/initscript_with_java.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-0> (18) * M compute/src/test/resources/initscript_with_jetty.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-1> (18) * M compute/src/test/resources/runscript.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-2> (18) * M compute/src/test/resources/runscript_adminUpdate.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-3> (4) * M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/domain/ShellToken.java<https://github.com/jclouds/jclouds/pull/150/files#diff-4> (2) * M scriptbuilder/src/main/resources/functions/setupPublicCurl.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-5> (14) * M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/domain/ShellTokenTest.java<https://github.com/jclouds/jclouds/pull/150/files#diff-6> (18) * M scriptbuilder/src/test/resources/test_ebs.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-7> (4) * M scriptbuilder/src/test/resources/test_find_pid.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-8> (2) * M scriptbuilder/src/test/resources/test_init.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-9> (4) * M scriptbuilder/src/test/resources/test_init_script.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-10> (4) * M scriptbuilder/src/test/resources/test_install_chef_gems_scriptbuilder.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-11> (4) * M scriptbuilder/src/test/resources/test_install_git_scriptbuilder.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-12> (18) * M scriptbuilder/src/test/resources/test_install_jdk_scriptbuilder.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-13> (18) * M scriptbuilder/src/test/resources/test_install_ruby_scriptbuilder.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-14> (18) * M scriptbuilder/src/test/resources/test_install_rubygems_scriptbuilder.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-15> (4) * M scriptbuilder/src/test/resources/test_runrun.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-16> (2) * M scriptbuilder/src/test/resources/test_runrun_header.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-17> (2) * M scriptbuilder/src/test/resources/test_script.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-18> (2) * M scriptbuilder/src/test/resources/test_seek_and_destroy.sh<https://github.com/jclouds/jclouds/pull/150/files#diff-19> (2) Patch Links: * https://github.com/jclouds/jclouds/pull/150.patch * https://github.com/jclouds/jclouds/pull/150.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/150#issuecomment-24524594
