> +    @Inject
> +    @Named(JoyentConstants.JOYENT_CERT_CLASSPATH)
> +    private String certClasspath_;
> +
> +
> +    @Inject
> +    public JoyentBlobRequestSigner(@org.jclouds.location.Provider
> +                                   Supplier<Credentials> creds) {
> +        identity = creds.get().identity;
> +    }
> +
> +    @Override
> +    public HttpRequest filter(HttpRequest request) throws HttpException {
> +        LOG.debug("signing request: " + request.getHeaders());
> +
> +        if (keyPair_ == null) {

Can we just declare the `keyPair` and `fingerprint` variables inside this 
`filter` method (not as a class member), so we can make this singleton class 
immutable? This should allow you to remove this synchronization and will 
considerably simplify this.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/188/files#r7140181

Reply via email to