Hi @vitaly-rudenya, thanks for your contribution! Adding a new provider is quite an important change for us, and we need to make sure it will work properly and we'll be able to properly test it (we'll going to maintain it!), so don't be discouraged by the review. We can go through the process together, and you can join the `#jclouds` IRC channel. We'll be happy to help with the changes! :)
Having said this, a couple of general considerations to take into account in your pull request: * New providers are added in labs first, until they are stable. This pull request should be closed and re-opened against the clouds-labs repo (revisit the groupId once you open the PR there). * To follow the jclouds style, use a 3 space indent and a 120 character line length. * Replace all those timestamps in the javadoc by descriptive comments. * Replace all the loggers by the clouds logger and remove the commons-logging dependency. * We use Guava as our core library. Try to use its utilities before adding new dependencies. * There are several places where you parse dates. Consider extending the [SimpleDateFormatDateService](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/date/internal/SimpleDateFormatDateService.java) and bind the `DateService.class` to your implementation, so you can inject your date service to all classes that need to parse dates and parse them in a generic way. * You added the live tests (great!), but there should also be "mock" tests. "mock" tests verify that the api generates the expected request according to the method annotations, and that the response is properly parsed. We use [mockwebserver](http://code.google.com/p/mockwebserver/) to do that, and you can take a look at the MockTests classes in the [openstack-swift](https://github.com/jclouds/jclouds-labs-openstack/tree/master/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features) api to see an example of how these tests work. Thanks again, and look forward to see progress on this. Will be happy to help and provide guidance! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/188#issuecomment-26856785
