> +         for (Location location : locations.get()) {
> +            groupCreator.invalidate(ZoneSecurityGroupNamePortsCidrs.builder()
> +                    .zone(location.getId())
> +                    .name(group.getName())
> +                    .build());
> +         }
> +
> +         return true;
> +      }
> +
> +      return false;
> +   }
> +
> +   @Override
> +   public SecurityGroup addIpPermission(IpPermission ipPermission, 
> SecurityGroup group) {
> +      String id = checkNotNull(group.getId(), "group.getId()");

Can a group have a null ID? And do we need to check for `group` being `null` 
here, too?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/152/files#r7377139

Reply via email to