> + for (IngressRule rule : filter(rawGroup.getIngressRules(),
> + ruleCidrMatches(ipPermission.getIpProtocol().toString(),
> + ipPermission.getFromPort(),
> + ipPermission.getToPort(),
> + ipPermission.getCidrBlocks()))) {
> +
> jobComplete.apply(api.getSecurityGroupApi().revokeIngressRule(rule.getId()));
> + }
> + }
> +
> + if (ipPermission.getTenantIdGroupNamePairs().size() > 0) {
> + for (IngressRule rule : filter(rawGroup.getIngressRules(),
> + ruleGroupMatches(ipPermission.getIpProtocol().toString(),
> + ipPermission.getFromPort(),
> + ipPermission.getToPort(),
> + ipPermission.getTenantIdGroupNamePairs()))) {
> +
> jobComplete.apply(api.getSecurityGroupApi().revokeIngressRule(rule.getId()));
Again, `try...catch`es around `revokeIngressRule` here and above to prevent
leaving a half-deleted state?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/152/files#r7377216
