On 26/08/13 19:08, Rob Vesse wrote:
Response inlines:
On 8/24/13 9:00 AM, "Andy Seaborne" <[email protected]> wrote:
Rob,
There'll need to be NOTICE and LICENSE files in the modules.
I have added these to the top level module, do they need to be in each
sub-module?
If the N&L files are in place, the build puts them in the jar as well so
it helps to have them in each place.
Is AspectJ used in all modules?
(Clerezza doesn't seem to have any NOTICE files at all - I don't
undertand how that can be.)
They are identical throughout, I assume we don't need to include
acknowledgements to ourselves in a NOTICE file since obviously the modules
depend on other Jena modules.
Yes.
There are no new runtime third party dependencies introduced, the modules
depend only on other Jena modules, JUnit and Log4j
Are the NOTICE and LICENSE that end up in the jars correct?
Currently I'm not sure these end up in the JARs at all, I'll look into
this. How do other modules achieve this?
IIRC N&L go into the jar by maven. (No - I don't know how!)
How does aspectj work? Does it cause anything to be shipped in the
jar(s)?
AspectJ basically inserts additional code into the class files at compile
time - essentially it is a code injection mechanism. This is used only to
add TRACE level method entry and exit logging which is useful when
debugging the use of the drivers with a new tool. Thus it is a compile
time only dependency.
However AspectJ is licensed under the Eclipse Public License which is
Category B at Apache so I presume we need to add an entry to the NOTICE
file for this and append the EPL to the License file?
Does AspectJ make any statement as to the License on the modified
compiled output?
No ...
http://eclipse.org/aspectj/doc/released/faq.php#q:license
<opinion>We do not absolutely require to include a statement because we
do not include source material.
If this is going to the distribution, then something needs to be in that
NOTICE (not the module one).
However, it is something the end user (rebuilder) may wish to be aware
of rebuilding from source and so, on balance, I'd put the statement in.
</opinion>
As a general comment - a seep through all the N&L to check and update to
current Apache practice would be good. There not so much "rules" as
"principles and practice". If we had an DEPENDENCES file we could use
that as a "long form" NOTICE area.
Andy
Rob
And since you've been through this more recently than anyone else, any
experience (e.g. plugins) we can learn and roll back into the other
build stuff?
Andy
