[ 
https://issues.apache.org/jira/browse/JENA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031546#comment-14031546
 ] 

Kristian Rosenvold commented on JENA-714:
-----------------------------------------

6. Replaces indexOf with contains
7.  A couple of cases of try -> try with resources
8. Uneccessary boxing/unboxing of integers/longs
9. A few while loops replaced with foreach

I did this with the code style we use in maven, which is similar to yours, but 
definitely not identical - which is what you're seeing. In maven we're quite 
strict about always reformatting to code style and we have well defined code 
style files for both eclipse and intellij, they are at 
http://maven.apache.org/developers/conventions/code.html and you could probably 
easily tweak them for your project. Given the existance of such a file, it is 
trivial to reformat the entire code base (intellij does that with one 
keypress). I dont know if you guys have written code style guide anywhere :)



> Language level upgrade
> ----------------------
>
>                 Key: JENA-714
>                 URL: https://issues.apache.org/jira/browse/JENA-714
>             Project: Apache Jena
>          Issue Type: Improvement
>            Reporter: Kristian Rosenvold
>            Assignee: Andy Seaborne
>         Attachments: languageLevel.patch
>
>
> The enclosed patch is a result of running a large number of automated 
> language level upgrades available in intellij Idea (about 4000 individual 
> items). 
> As such, the patch contains no "manual" changes done by hand, and should be 
> safe to apply, if somewhat large :)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to